Patch Set 1: Code-Review-1 (2 comments)
https://gerrit.osmocom.org/#/c/4915/1/tests/gtp/gtpie_test.c File tests/gtp/gtpie_test.c: Line 32: memcpy(&u16, &buf[1], sizeof(u16)); why not simply use osmo_load16_be() ? it does the unaligned load without memcpy, another variable declaration and without the need for an ntohs Line 98: memcpy(&u32, &buf[1], sizeof(u32)); osmo_load32be -- To view, visit https://gerrit.osmocom.org/4915 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9eb16450af942d6464211e190f6a4d5a1d814842 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
