Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/28782 )

Change subject: in sdp logging: add payload type number like 'AMR#111'
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

File src/libmsc/sdp_msg.c:

https://gerrit.osmocom.org/c/osmo-msc/+/28782/comment/2d4e2d64_d6aac20b
PS3, Line 516:  OSMO_STRBUF_PRINTF(sb, "#%d", codec->payload_type);
does it makes sense that this is a %d and not a %u?



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28782
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Icbb4e89ce2947bf787c3ee14e3e115d406e43de2
Gerrit-Change-Number: 28782
Gerrit-PatchSet: 3
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Mon, 25 Jul 2022 14:34:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to