Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28756 )
Change subject: trxcon: use trxcon->fi as the context in L1CTL logging ...................................................................... Patch Set 8: (1 comment) File src/host/trxcon/src/trxcon.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28756/comment/2d67d21b_c6ec2e41 PS7, Line 392: l1c->log_prefix = talloc_strdup(l1c, trxcon->log_prefix); > just to be sure, is it possible that there may be a leak here? > osmo_talloc_replace? trxcon->log_prefix is a chunk that belongs to trxcon (parent context). Whenever we free() trxcon, trxcon->log_prefix gets free()d too. There should not be memleak here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28756 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7b923cb21638e6afc38deb7766955b43e49b60bb Gerrit-Change-Number: 28756 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 25 Jul 2022 17:56:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
