laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/28770 
)

Change subject: apdu/ts_102_221: SELECT: allow select of SELF
......................................................................

apdu/ts_102_221: SELECT: allow select of SELF

While in the pySim-shell, it's useful to filter the currently selected
file from the choice of available files for select, this doesn't apply
for the tracing case: It's perfectly valid for the UE to SELECT the
file that's already selected right now.  The operation basically
becomes equivalent to a STATUS.

Change-Id: I1a20fb3ba70426333ac34448c6cb782c51363965
---
M pySim/apdu/ts_102_221.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/pySim/apdu/ts_102_221.py b/pySim/apdu/ts_102_221.py
index 769c38e..fb2f375 100644
--- a/pySim/apdu/ts_102_221.py
+++ b/pySim/apdu/ts_102_221.py
@@ -66,7 +66,7 @@
                     # iterate to next element in path
                     continue
                 else:
-                    sels = 
lchan.selected_file.get_selectables(['FIDS','MF','PARENT'])
+                    sels = 
lchan.selected_file.get_selectables(['FIDS','MF','PARENT','SELF'])
                     if file_hex in sels:
                         if self.successful:
                             #print("\tSELECT %s" % sels[file_hex])
@@ -80,7 +80,7 @@
         elif mode == 'df_ef_or_mf_by_file_id':
             if len(self.cmd_data) != 2:
                 raise ValueError('Expecting a 2-byte FID')
-            sels = lchan.selected_file.get_selectables(['FIDS','MF','PARENT'])
+            sels = 
lchan.selected_file.get_selectables(['FIDS','MF','PARENT','SELF'])
             file_hex = b2h(self.cmd_data)
             if file_hex in sels:
                 if self.successful:



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28770
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I1a20fb3ba70426333ac34448c6cb782c51363965
Gerrit-Change-Number: 28770
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged

Reply via email to