pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/28804 )
Change subject: sbcap: Tx Error ind if Rx ProcedureCode is unknown
......................................................................
sbcap: Tx Error ind if Rx ProcedureCode is unknown
Change-Id: I3ee760b98d87f179917acbc369f56d72d0db571d
---
M src/sbcap_link_fsm.c
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
fixeria: Looks good to me, approved
diff --git a/src/sbcap_link_fsm.c b/src/sbcap_link_fsm.c
index 3135f1f..4f89c3c 100644
--- a/src/sbcap_link_fsm.c
+++ b/src/sbcap_link_fsm.c
@@ -28,6 +28,7 @@
#include <osmocom/cbc/cbc_message.h>
#include <osmocom/cbc/sbcap_link.h>
#include <osmocom/cbc/sbcap_link_fsm.h>
+#include <osmocom/cbc/sbcap_msg.h>
#include <osmocom/cbc/debug.h>
#include <osmocom/cbc/cbc_peer.h>
#include <osmocom/cbc/smscb_message_fsm.h>
@@ -258,6 +259,7 @@
{
struct cbc_message *smscb;
struct cbc_message_peer *mp;
+ SBcAP_SBC_AP_PDU_t *err_ind_pdu;
int msg_id;
/* messages without reference to a specific SMSCB message */
@@ -282,7 +284,13 @@
break; /* Handle msg id below */
default:
LOGPSBCAPC(link, LOGL_ERROR, "SBcAP initiatingMessage
procedure=%ld not implemented?\n",
- pdu->choice.initiatingMessage.procedureCode);
+ pdu->choice.initiatingMessage.procedureCode);
+ err_ind_pdu = sbcap_gen_error_ind(link,
SBcAP_Cause_valid_message_not_identified, pdu);
+ if (err_ind_pdu)
+ cbc_sbcap_link_tx(link, err_ind_pdu);
+ else
+ LOGPSBCAPC(link, LOGL_ERROR,
+ "Tx SBc-AP Error-Indication: msg gen
failed\n");
return 0;
}
break;
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted
one.
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28804
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I3ee760b98d87f179917acbc369f56d72d0db571d
Gerrit-Change-Number: 28804
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
