pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-cbc/+/28803 )

Change subject: sbcap: Improve logging on non-implemented PWS Restart/Failure 
Ind
......................................................................

sbcap: Improve logging on non-implemented PWS Restart/Failure Ind

Change-Id: I0085ac40a7676d9c3626a9da38d02d3b1b2cf6b4
---
M src/sbcap_link_fsm.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, approved



diff --git a/src/sbcap_link_fsm.c b/src/sbcap_link_fsm.c
index 39dd281..3135f1f 100644
--- a/src/sbcap_link_fsm.c
+++ b/src/sbcap_link_fsm.c
@@ -80,7 +80,7 @@
                //pdu = data;
                /* TODO: delete any CBS state we have for this peer */
                /* TODO: re-send messages we have matching the scope of the 
peer */
-               LOGPSBCAPC(link, LOGL_NOTICE, "RESTART  but re-sending not 
implemented yet\n");
+               LOGPSBCAPC(link, LOGL_NOTICE, "Rx PWS Restart Indication not 
implemented yet\n");
                break;
        default:
                OSMO_ASSERT(0);
@@ -274,10 +274,12 @@
                        return osmo_fsm_inst_dispatch(link->fi, 
SBcAP_LINK_E_RX_RESTART, pdu);
                case SBcAP_ProcedureId_Error_Indication:
                        return cbc_sbcap_link_rx_error_ind(link, pdu);
+               case SBcAP_ProcedureId_PWS_Failure_Indication:
+                       LOGPSBCAPC(link, LOGL_NOTICE, "Rx PWS Failure 
Indication not implemented yet\n");
+                       return 0;
                case SBcAP_ProcedureId_Stop_Warning_Indication:
                case SBcAP_ProcedureId_Write_Replace_Warning_Indication:
                        break; /* Handle msg id below */
-               case SBcAP_ProcedureId_PWS_Failure_Indication:
                default:
                        LOGPSBCAPC(link, LOGL_ERROR, "SBcAP initiatingMessage 
procedure=%ld not implemented?\n",
                               pdu->choice.initiatingMessage.procedureCode);



4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28803
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I0085ac40a7676d9c3626a9da38d02d3b1b2cf6b4
Gerrit-Change-Number: 28803
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged

Reply via email to