Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28963 )
Change subject: pySim.transport: Add mechanism for handling for CAT/USAT proactive cmds ...................................................................... Patch Set 4: (2 comments) File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/28963/comment/ba5f5046_cbc15b4e PS4, Line 57: receive_fetch > Rather decorate with @abc.abstractmethod, no need to raise > NotImplementedError. the point here is that you don't neccessarily need to provide a receive_fetch method in your derived class. you only need it _if_ you don't implement the various handle_xxx methods. That's why I did it this way. https://gerrit.osmocom.org/c/pysim/+/28963/comment/bb7c4316_ed7c0f67 PS4, Line 164: while > Could you explain why are you changing 'if' to 'while'? the existing code only handled one proactive response, and then interjected the FETCH command. However, if that FETCH command again reuslts in a 91xx response, it means there's another proactive command pending, and we need to do another FETCH, and repeat. This could/should have been a separate patch, but given that nobody is using the code yet, and the entire proactive support is pretty much WIP, I thought I can avoid creating even more one-line commits. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I844504e2fc1b27ce4fc7ede20b2307e698baa0f6 Gerrit-Change-Number: 28963 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Sun, 07 Aug 2022 15:04:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
