Patch Set 3: Code-Review+1 (1 comment)
https://gerrit.osmocom.org/#/c/4900/3/src/osmo-mgw/mgw_main.c File src/osmo-mgw/mgw_main.c: Line 301: perror("Gateway failed to bind"); (this error reporting is different from the others... even though the patch is adopting the previous style, shouldn't this be LOGP with addr+port, possibly strerror()? After all we LOGP on success a few lines further down) -- To view, visit https://gerrit.osmocom.org/4900 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39d47b8a27f683060a2facf2dbecff8d00c19ce9 Gerrit-PatchSet: 3 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-HasComments: Yes
