Patch Set 1: To elaborate further. Before this change I had to know what test_successive_allocation is doing. If I understand it correctly you are confused that for min_class and max_class sometimes the same class and sometimes different classes are passed.
You try to solve this by introducing another method for the min_class == max_class case and put _single as suffix to the method name. With bike shedding maybe _single_class _one_class might be better but the point is.. after the change one needs to know the original method with all its parameters and now the overload as well. >From my point of view this is not an improvement. The human brain can only >keep a few things in its memory/registers. So by knowing the new overload, >something else must be spilled. I don't think a _single function in a test >adds so much value to spill something else... leave alone to spend time >changing it right now. -- To view, visit https://gerrit.osmocom.org/4956 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3feeb92237ffb9557ac6998540b740f1f67186b3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: No
