Attention is currently required from: neels, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 )
Change subject: Log more data on CR and N-CONNECT ...................................................................... Patch Set 8: Code-Review-1 (1 comment) Patchset: PS8: I also think it's not entirely customary to log the size of each message we're sending. This can easily be done with wireshark, or with a debugger/tracepoint or (like I'd do it these days) some kind of bfptrace program attached to the specific funciton. the latter can even draw you nice histogram of message sizes with something like 5 lines of code. At zero overhead for the normal non-debug use case. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:40:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
