Patch Set 2: Code-Review+2 (1 comment)
https://gerrit.osmocom.org/#/c/4906/2/src/libosmo-mgcp/mgcp_conn.c File src/libosmo-mgcp/mgcp_conn.c: Line 109: strncpy(conn->id, id, sizeof(conn->id)); osmo_strlcpy to avoid unterminated buffers, in case the input string exceeds the output size (which is a violation of protocol, but we should rather be safe -- To view, visit https://gerrit.osmocom.org/4906 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0531a1b670d00cec50078423a2868207135b2436 Gerrit-PatchSet: 2 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
