Attention is currently required from: neels, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29158 )
Change subject: cosmetic: add spec reference ...................................................................... Patch Set 1: (1 comment) File src/sua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29158/comment/b2f7a3fb_1fd13581 PS1, Line 184: /* ITU-T Rec Q.713 */ > this spec is about SCCP, not SUA? Background: SUA is a (much younger, IETF-provided) alternative protocol for (SCCP+MTP). As SUA functionality is a superset of SCCP (you can express everything possible in SCCP with SUA, but SUA has some additional bits you cannot express in SCCP) I decided that our stack internally uses SUA, and only transcodes to SCCP when SCCP is needed. The SUA spec often falls back on SCCP. I think it's useful to add these kind of annotations, but if one wants to do that, one should first mention the SUA RFC section and then the ITU-T reference, something like "RFC1234 section 3.4 resembling Q.714 Secion 4.2" or the like. However, given that the task at hand was not to improve the documentation of our SIGTRAN code but to implement a specific message size limit, I don't think it is worth investing time -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d6bf9d0e681db779770b2fb815f7f9c5e608b15 Gerrit-Change-Number: 29158 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Sat, 20 Aug 2022 08:20:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Gerrit-MessageType: comment
