Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29082 )
Change subject: Log more details in osmo_stream_srv_write() ...................................................................... Patch Set 2: (1 comment) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29082/comment/5a3b30ff_195c87a7 PS2, Line 1334: ret Somehow I missed this. According to man: "Upon successful completion, send() shall return the number of bytes sent. Otherwise, -1 shall be returned and errno set to indicate the error." So here you should do strerror(errno) instead. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I580c00f3b5ade05ecb20a92ce4ece2854334a41f Gerrit-Change-Number: 29082 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: msuraev <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Sun, 21 Aug 2022 13:13:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
