msuraev has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/29159 )

Change subject: [cosmetic] sccp_scoc.c: constify function parameters
......................................................................


Patch Set 3:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmo-sccp/+/29159/comment/2c7feda3_51b7efd1
PS1, Line 7: cosmetic: constify function parameters, return proper error
> the summary should indicate the scope ("sccp_scoc.c:... […]
Done


File src/sccp_scoc.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/29159/comment/b7b8ce1a_5a5bc755
PS1, Line 704:          return -ENOMSG;
> -ENOMEM would be the proper code here. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29159
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I398e3efa3e097de8907617cfdf363e1d3b96f666
Gerrit-Change-Number: 29159
Gerrit-PatchSet: 3
Gerrit-Owner: msuraev <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: msuraev <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Comment-Date: Sun, 21 Aug 2022 15:07:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Gerrit-MessageType: comment

Reply via email to