Attention is currently required from: neels, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 )
Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 11: (8 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/a3b110f7_3d86edbc PS8, Line 9: Limit length of optional Data parameter is 130 bytes according to ITU-T Rec Q.713 §4.2..§4.5. If we receive CR, CC or > This reads a bit weird. […] Done File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/f0100bc3_6bdeaec6 PS8, Line 50: #include <osmocom/core/msgb.h> > cosmetic: move it below to other imports from 'osmocom/core'. Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/ecc3dca8_51692095 PS8, Line 603: xua_class_msg_name > xua_class_msg_name() operates on a static buffer, so calling it more than > once in a logging statemen […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/76e546b0_6f13dea0 PS8, Line 613: lim > IIUC, this value is always SCCP_MAX_DATA. […] No, it's not. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/36748543_09562d0c PS8, Line 623: xua_opt_data_cache_check > When I see function names ending with _check, I expect them to do nothing > else but check something a […] Renamed and updated docs for clarity. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/7c59d29f_d77102b1 PS8, Line 650: static bool xua_opt_data_length_check(struct sccp_connection *conn, const struct osmo_scu_prim *prim, int msg_type) > Again, this naming is really confusing. […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/7a9c0031_0ad8e9b7 PS8, Line 659: break > unreachable Yes? https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/08795265_cff33e10 PS8, Line 1006: xua_opt_data_clear_cache > IMO, this should be done in conn_destroy(). Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 11 Gerrit-Owner: msuraev <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:28:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
