Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29142 )
Change subject: debian: add missing deps ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File debian/control: https://gerrit.osmocom.org/c/osmo-upf/+/29142/comment/12c8b3ed_23f59051 PS1, Line 16: see my comment in https://gerrit.osmocom.org/c/osmo-upf/+/29188 - I don't see any evidence of osmo-upf using libnftnl directly. It seems to use exclusively the libnftables API. The fact that libnftables uses some other upstream libraries is of no concern to us. That's something the libnftables pkg-config/dpkg/rpm have to manage. So rather than adding the libnftnl-dev here, I think it should be removed from configure.ac or any other place in osmo-upf. Please correct me if I overlooked any direct use of libnftnl by osmo-upf. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I068736d513ddb54b9a62c1d7970a0fbff3095b4b Gerrit-Change-Number: 29142 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Tue, 23 Aug 2022 17:33:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
