Attention is currently required from: fixeria.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-gprs/+/29207 )

Change subject: rlcmac: make logging category configurable
......................................................................


Patch Set 1:

(1 comment)

File src/rlcmac/gprs_rlcmac.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/29207/comment/996738e5_5863263b
PS1, Line 38: e
are we sure that this is not globally exported by the library? If you introduce 
symbols with such generic names, they must be kept private by the library (e.g. 
by using a *.map file to export only some symbols explicitly).



--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29207
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Icfef6de126304da81120f1d7b212992ead3409aa
Gerrit-Change-Number: 29207
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 24 Aug 2022 15:42:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to