Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/4977/2/src/hnbgw_cn.c
File src/hnbgw_cn.c:

Line 474:               ss7->cfg.primary_pc = (23 << 3) + 5;
maybe a comment pointing to the wiki page? Or add #defines  like we have for 
tcp/udp port numbers?


-- 
To view, visit https://gerrit.osmocom.org/4977
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I056547f26858d3ad52e66a15f7a4273dcc300e97
Gerrit-PatchSet: 2
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-HasComments: Yes

Reply via email to