Patch Set 1: Code-Review+2 (1 comment)
https://gerrit.osmocom.org/#/c/5019/1/src/gprs/sgsn_main.c File src/gprs/sgsn_main.c: Line 507: (23 << 3) + 4, see my related comment on the MSC change. We should have at least a #define POINTCODE_ITU_383(0,23,4), and then probably also #defines for the individual default point coes, like we have for TCP/UDP ports? That could be a follow-up patch, hence +2 for fixing a bug. -- To view, visit https://gerrit.osmocom.org/5019 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie11f1dfcdd5889d44fefe6cc10472ef1a794cc64 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
