Patch Set 3: (1 comment)
https://gerrit.osmocom.org/#/c/4779/3/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: Line 1296: g_cfg->trunk.number_endpoints = g_cfg->trunk.vty_number_endpoints; > -1: rather assign the number of allocated endpoints only after allocation, hmm ok, I see the mgcp_endpoints_allocate() kind of uses the number_endpoints as argument. Technically the cleanest approach would be to change the API to pass the number that should be allocated as argument to the function, but in terms of least code change you could also set number_endpoints = 0 in case of error. -- To view, visit https://gerrit.osmocom.org/4779 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3994af016fb96427263edbba05f560743f85fdd4 Gerrit-PatchSet: 3 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
