Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/5009/1/src/osmo_gsm_tester/modem.py File src/osmo_gsm_tester/modem.py: Line 340: CTX_PROT_IPv46 = 'dual' (is this used internally only? I'd suggest using the same strings as you've chosen for the names of the constants) wait a minute, where *is* this used anyway? -- To view, visit https://gerrit.osmocom.org/5009 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I605ba1bb1103a045a9b5d0e7215c05dfc1fe575f Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
