pespin has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/29466 )
Change subject: tests/osmo-pcap-test/osmux_test: Fix return condition check for
osmux_xfrm_input()
......................................................................
tests/osmo-pcap-test/osmux_test: Fix return condition check for
osmux_xfrm_input()
According to API doc and implementation, it never returns >1.
Do as done in all other places where this API is used, that this check
for >0.
Change-Id: If23dfecb566f590b7a898356469df6e322f57653
---
M tests/osmo-pcap-test/osmux_test.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/tests/osmo-pcap-test/osmux_test.c
b/tests/osmo-pcap-test/osmux_test.c
index e6bbeb1..a1aa199 100644
--- a/tests/osmo-pcap-test/osmux_test.c
+++ b/tests/osmo-pcap-test/osmux_test.c
@@ -124,7 +124,7 @@
if (ccid < 0)
register_ccid(rtph->ssrc);
- while ((ret = osmux_xfrm_input(&h_input, msg, ccid)) > 1) {
+ while ((ret = osmux_xfrm_input(&h_input, msg, ccid)) > 0) {
/* batch full, deliver it */
osmux_xfrm_input_deliver(&h_input);
}
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29466
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: If23dfecb566f590b7a898356469df6e322f57653
Gerrit-Change-Number: 29466
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
