Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29512 )
Change subject: osmux: Proper encoding of osmux frames when when AMR FT changes ...................................................................... Patch Set 1: Code-Review+2 (2 comments) File src/osmux.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29512/comment/8a360230_5d7dc04c PS1, Line 470: !state.rtph > Why are you changing this? I guess because below in your code you're doing > !foo. […] I just really rewrote the whole code several times before finding the best way, so it ended up this way. https://gerrit.osmocom.org/c/libosmo-netif/+/29512/comment/e3863d66_a8d8bdc1 PS1, Line 535: struct amr_hdr *amrh > const? I'll do a full pass of constifying everything possible in a follow up patch, I bet several things can be marked as const. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I25eb6ee54c898f575cc71ccfd6d190fe51d56dbe Gerrit-Change-Number: 29512 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 29 Sep 2022 09:32:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
