Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29537 )
Change subject: power_control: add CTRL command for sending default params ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-bsc/bsc_ctrl_commands.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29537/comment/671f8a10_d7bdbdd2 PS2, Line 315: cmd->reply = "Default power control parameters have been sent"; I would really simply write "OK" here, this looks way to verbose imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib370bd97ee2d9f72f8bec553550b1792d1345387 Gerrit-Change-Number: 29537 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 29 Sep 2022 21:01:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
