Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29547 )

Change subject: Close conn when receiving SCTP_ASSOC_CHANGE notification
......................................................................


Patch Set 1:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/29547/comment/dd5562a4_db59b8a1
PS1, Line 9: It was seen on a real pcap trace (sctp & gsmtap_log) that the 
kernel
> i read this before and commented it, can you "link" the patches by a […]
Related: SYS#6113, it's already there.

The patches (his and the other one) you mention are ortoghonal/independent.

Other patch: The libosmo-netif patch returns 0 in order for callers not wishing 
to take care of SCTP notification flags closing properly the conn when 
receiving return code 0.

This pach: This is the only caller which make use of flags, and hence must also 
take that one into account.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29547
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: If35efd404405f926a4a6cc45862eeadd1b04e08c
Gerrit-Change-Number: 29547
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: neels <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Fri, 30 Sep 2022 14:40:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Gerrit-MessageType: comment

Reply via email to