Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29551 )
Change subject: vty: 'hopping arfcn add': succeed if adding arfcn already in set ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I intentionally added this check in Ie27c859e3f16ada08a5cdc8ab4ac6e20a885a378 > to facilitate finding […] What do you mean with duplicate here? Using the command twice creates no duplicate at all in the set, so it should be totally fine. Why would you want to stop osmo-bsc from starting? because that command is set twice? that is really agressive and I see no necessity for that. Furthermore it is creating problems with apply-config-file for no good reason, so let's avoid blocking reading config files which have commands being applied twice changing no state. If at all, print some warning to make the user notice that this one was already added, so that they can see and check if they had a typo, but that's all. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29551 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia4e70d20d48a28c46a21dd10358577e5c798744c Gerrit-Change-Number: 29551 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Sat, 01 Oct 2022 19:15:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
