Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29528 )
Change subject: osmux: Allocate struct osmux_out_handle through API ...................................................................... Patch Set 1: (1 comment) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29528/comment/c8102dcf_c92558ef PS1, Line 737: /* DEPRECATED: Use talloc_free() instead (will call osmux_xfrm_input_talloc_destructor()) */ > What are the benefits of using a talloc destructor? If I allocate something > with talloc, then yes, I […] I chose to use a talloc destructor because it makes it easier to destroy the object when the parent object is destroy and make sure stuff is not left around. This is useful for existing users to transition to the new talloc allocated API, since they don't need necessarily to care about finding out where to destroy the object in the existing code. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I752ab031f935f04731bb1a354333f1682a1aa5bd Gerrit-Change-Number: 29528 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 03 Oct 2022 09:19:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
