Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29524 )
Change subject: osmux: Split input and output code into separate files ...................................................................... Patch Set 2: (7 comments) File src/osmux_input.c: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-128): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/70572c2c_850141ac PS2, Line 181: osmuxh->amr_q= 0; spaces required around that '=' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-128): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/12c06b9d_908b2d45 PS2, Line 373: for (i=1; i<diff; i++) { spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-128): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/15bbfcbe_b0eb6585 PS2, Line 373: for (i=1; i<diff; i++) { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-128): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/01a1cf8e_3cf49a9a PS2, Line 559: switch(rtph->payload_type) { switch and case should be at the same indent Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-128): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/982b8b12_bf84c309 PS2, Line 559: switch(rtph->payload_type) { space required before the open parenthesis '(' File src/osmux_output.c: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-128): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/4214ae37_7919f680 PS2, Line 206: * them for transmission at appropiate time. 'appropiate' may be misspelled - perhaps 'appropriate'? Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-netif-lint-128): https://gerrit.osmocom.org/c/libosmo-netif/+/29524/comment/da4f0a4a_7ada907a PS2, Line 255: if(was_empty && !llist_empty(&h->list)) space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia72995092a36ca50147611e617cb88c4dcf231d5 Gerrit-Change-Number: 29524 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 03 Oct 2022 09:31:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
