fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/29562 )
Change subject: mncc: move MNCC_F_ALL from mncc.c to mncc.h
......................................................................
mncc: move MNCC_F_ALL from mncc.c to mncc.h
Move it closer to the other MNCC_F_* entries, so that it's more
likely that it gets updated when new flags are added.
Change-Id: If1a12a696b87184c9eee14f475594c317927427b
Related: OS#5282
---
M include/osmocom/msc/mncc.h
M src/libmsc/mncc.c
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
keith: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Objections:
pespin: I would prefer this is not merged as is
diff --git a/include/osmocom/msc/mncc.h b/include/osmocom/msc/mncc.h
index 06a5dcc..8a1e4ad 100644
--- a/include/osmocom/msc/mncc.h
+++ b/include/osmocom/msc/mncc.h
@@ -126,6 +126,9 @@
#define MNCC_F_SIGNAL 0x2000
#define MNCC_F_GCR 0x4000
+/* UPDATEME when adding new MNCC_F_* entries above */
+#define MNCC_F_ALL 0x7fff
+
struct gsm_mncc {
/* context based information */
uint32_t msg_type;
diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c
index f446f98..24e79a7 100644
--- a/src/libmsc/mncc.c
+++ b/src/libmsc/mncc.c
@@ -110,8 +110,6 @@
* MNCC validation code. Move to libosmocore once headers are merged
************************************************************************/
-#define MNCC_F_ALL 0x7fff
-
static int check_string_terminated(const char *str, unsigned int size)
{
int i;
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29562
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If1a12a696b87184c9eee14f475594c317927427b
Gerrit-Change-Number: 29562
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: keith <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
