Patch Set 6: (4 comments)
...and some more. https://gerrit.osmocom.org/#/c/4905/6/src/libosmo-mgcp/mgcp_conn.c File src/libosmo-mgcp/mgcp_conn.c: Line 42: rc = osmo_get_rand_id(id_bin, sizeof(id_bin)); er... so we do 32 attempts at creating a random id? Why not just count the number of connections and express that as hex? I think this choice deserves an explanation in a comment. What's the rationale behind it? Line 50: /* ensure that the generated conn_id is unuque "unique" Line 51: * for the current this endpoint */ "current this" Line 57: with usually only two conn ids per endpoint, it's unlikely to fail, but if it does, that deserves logging. -- To view, visit https://gerrit.osmocom.org/4905 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab6a6038e7610c62f34e642cd49c93d11151252c Gerrit-PatchSet: 6 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
