Attention is currently required from: laforge, dexter.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/29591 )

Change subject: msgb: dont return a length when msgb->lXh is NULL
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1:
Let's better OSMO_ASSERT() there, I run myself into this sort of problem in the 
past and it's really costly to find out what's going on.
Maybe even better, use osmo_panic() explaining the error before asserting.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29591
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1795c559f190713ebbabfbabf3453ab77da46a49
Gerrit-Change-Number: 29591
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 04 Oct 2022 14:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to