Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29589 )
Change subject: Get rid of separate rtp_port field ...................................................................... Patch Set 3: (1 comment) File include/osmocom/mgcp/mgcp_network.h: https://gerrit.osmocom.org/c/osmo-mgw/+/29589/comment/8ee2ece1_b2840b82 PS3, Line 96: int rtp_port, rtcp_port > To me it looks like it was done on purpose: there is not only rtp_port, but > also rtcp_port. […] The rtcp_port can also be dropped completely, since it's basically rtp_port+1 in all cases. The inconsistency of having a sockaddr which gets its port part set and used in different places while keeping this rtp_port is A LOT worse. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I294eb5d85fae79bf62d36eb9e818426e187d442c Gerrit-Change-Number: 29589 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 04 Oct 2022 15:21:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
