Patch Set 1: (1 comment)
Ok, I'll improvie the commit description https://gerrit.osmocom.org/#/c/5011/1/suites/gprs/ping.py File suites/gprs/ping.py: Line 45: ctx_id_v4 = ms.activate_context(apn='internet', protocol=ms.CTX_PROT_IPv4) > is ms.activate_context() blocking? For the ms.attach() we chose to go for n activate_context is blocking for now, to simplify the API. We can move it to non-blocking later if we see any use for it, but I don't think it's that important. I have no strong opinion on it being one way or the other. For attach(), I made it non-blocking because we can enable that early (see attach being used right after connect) and we may speed up the tests as it may become attached during registering time. -- To view, visit https://gerrit.osmocom.org/5011 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8695029cb7a43cd48f650c88f38b4c054da0bc6b Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-HasComments: Yes
