Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29905 )
Change subject: Delay ImmAss(PCH, PktDlAss) if waiting for PKT_CTRL_ACK answering UL_ACK_NACK (FinACK=1) ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/29905/comment/ff284e0f_b7fe58c1 PS2, Line 388: something is wrong should it log an error message in both if code paths then? File src/tbf_fsm.c: https://gerrit.osmocom.org/c/osmo-pcu/+/29905/comment/b6479671_c27a38d7 PS2, Line 265: thr the -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29905 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7a30db9cc7dae70e04054f1a4dba004bd1780d4a Gerrit-Change-Number: 29905 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 28 Oct 2022 12:53:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
