Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918 )
Change subject: import latest e1-tracer host software ...................................................................... Patch Set 1: (41 comments) File software/e1-tracer/crc4itu.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/1d987454_ba74ff84 PS1, Line 18: * The crc4itu_init() function returns the inital \c crc value and must be called 'inital' may be misspelled - perhaps 'initial'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/74738e19_ddb52a0f PS1, Line 65: typedef uint_fast8_t crc_t; do not add new typedefs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/03addd71_030d2028 PS1, Line 75: return 0x0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/b97966e7_9018e043 PS1, Line 98: return crc; please, no spaces at the start of a line File software/e1-tracer/crc4itu.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/518534eb_5347429f PS1, Line 26: 0x00, 0x03, 0x06, 0x05, 0x0c, 0x0f, 0x0a, 0x09, 0x0b, 0x08, 0x0d, 0x0e, 0x07, 0x04, 0x01, 0x02, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/ae4c971a_6cb406df PS1, Line 27: 0x05, 0x06, 0x03, 0x00, 0x09, 0x0a, 0x0f, 0x0c, 0x0e, 0x0d, 0x08, 0x0b, 0x02, 0x01, 0x04, 0x07, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/16229274_4b1975a2 PS1, Line 28: 0x0a, 0x09, 0x0c, 0x0f, 0x06, 0x05, 0x00, 0x03, 0x01, 0x02, 0x07, 0x04, 0x0d, 0x0e, 0x0b, 0x08, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/f6144a71_29f7f199 PS1, Line 29: 0x0f, 0x0c, 0x09, 0x0a, 0x03, 0x00, 0x05, 0x06, 0x04, 0x07, 0x02, 0x01, 0x08, 0x0b, 0x0e, 0x0d, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/45a617c7_d9d75474 PS1, Line 30: 0x07, 0x04, 0x01, 0x02, 0x0b, 0x08, 0x0d, 0x0e, 0x0c, 0x0f, 0x0a, 0x09, 0x00, 0x03, 0x06, 0x05, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/190b9464_7c206e19 PS1, Line 31: 0x02, 0x01, 0x04, 0x07, 0x0e, 0x0d, 0x08, 0x0b, 0x09, 0x0a, 0x0f, 0x0c, 0x05, 0x06, 0x03, 0x00, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/c5b96485_557b262a PS1, Line 32: 0x0d, 0x0e, 0x0b, 0x08, 0x01, 0x02, 0x07, 0x04, 0x06, 0x05, 0x00, 0x03, 0x0a, 0x09, 0x0c, 0x0f, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/96af5a33_3f0cd1ef PS1, Line 33: 0x08, 0x0b, 0x0e, 0x0d, 0x04, 0x07, 0x02, 0x01, 0x03, 0x00, 0x05, 0x06, 0x0f, 0x0c, 0x09, 0x0a, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/644af630_17eb3ca2 PS1, Line 34: 0x0e, 0x0d, 0x08, 0x0b, 0x02, 0x01, 0x04, 0x07, 0x05, 0x06, 0x03, 0x00, 0x09, 0x0a, 0x0f, 0x0c, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/2a5a591d_a0322d64 PS1, Line 35: 0x0b, 0x08, 0x0d, 0x0e, 0x07, 0x04, 0x01, 0x02, 0x00, 0x03, 0x06, 0x05, 0x0c, 0x0f, 0x0a, 0x09, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/577f463c_8b11e44c PS1, Line 36: 0x04, 0x07, 0x02, 0x01, 0x08, 0x0b, 0x0e, 0x0d, 0x0f, 0x0c, 0x09, 0x0a, 0x03, 0x00, 0x05, 0x06, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/52342cdd_33f65d10 PS1, Line 37: 0x01, 0x02, 0x07, 0x04, 0x0d, 0x0e, 0x0b, 0x08, 0x0a, 0x09, 0x0c, 0x0f, 0x06, 0x05, 0x00, 0x03, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/236802eb_d2fbae83 PS1, Line 38: 0x09, 0x0a, 0x0f, 0x0c, 0x05, 0x06, 0x03, 0x00, 0x02, 0x01, 0x04, 0x07, 0x0e, 0x0d, 0x08, 0x0b, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/92b8064f_65a431b5 PS1, Line 39: 0x0c, 0x0f, 0x0a, 0x09, 0x00, 0x03, 0x06, 0x05, 0x07, 0x04, 0x01, 0x02, 0x0b, 0x08, 0x0d, 0x0e, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/f477c54c_291139fc PS1, Line 40: 0x03, 0x00, 0x05, 0x06, 0x0f, 0x0c, 0x09, 0x0a, 0x08, 0x0b, 0x0e, 0x0d, 0x04, 0x07, 0x02, 0x01, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/37feda0a_df0a67d0 PS1, Line 41: 0x06, 0x05, 0x00, 0x03, 0x0a, 0x09, 0x0c, 0x0f, 0x0d, 0x0e, 0x0b, 0x08, 0x01, 0x02, 0x07, 0x04 please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/50dd7ea1_6707e365 PS1, Line 47: const unsigned char *d = (const unsigned char *)data; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/84343010_546a915a PS1, Line 48: unsigned int tbl_idx; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/6988323f_caccb5fd PS1, Line 50: while (data_len--) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/a63528ba_8a310853 PS1, Line 51: tbl_idx = (crc << 4) ^ *d; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/13c1faf0_56fe1799 PS1, Line 51: tbl_idx = (crc << 4) ^ *d; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/4596a464_d8fdfb6a PS1, Line 52: crc = crc_table[tbl_idx] & 0xf; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/a1ed25f3_c2338c1a PS1, Line 52: crc = crc_table[tbl_idx] & 0xf; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/a336800d_b1983622 PS1, Line 53: d++; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/2d20aeff_ef777a24 PS1, Line 53: d++; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/372a0685_72a518aa PS1, Line 54: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/5d1eb4b7_a70402c6 PS1, Line 55: return crc & 0xf; please, no spaces at the start of a line File software/e1-tracer/dump.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/93f8c678_1da5653c PS1, Line 17: * with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/6673f40b_3d00ee64 PS1, Line 18: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. File software/e1-tracer/hdlc-decode-pipe.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/9799f50f_5584a58f PS1, Line 17: * with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/ae94a62c_462c3d57 PS1, Line 18: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. File software/e1-tracer/idt82v2081_regs.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/8fbb978a_2711e298 PS1, Line 37: #define IDT_GCF_T1E1_E1 (0 << 2) please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/5567aa34_4881caca PS1, Line 38: #define IDT_GCF_T1E1_T1 (1 << 2) please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/77b5ed02_626079ad PS1, Line 39: #define IDT_GCF_T1E1_MASK (1 << 2) please, no space before tabs File software/e1-tracer/osmo_e1f.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/c9b4d51c_bf2bd54f PS1, Line 189: } else { else is not generally useful after a break or return File software/e1-tracer/replay.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/414b715b_b8c748e5 PS1, Line 17: * with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-570): https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918/comment/1639247d_c53d1a30 PS1, Line 18: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I9319c1eb8f822830307c1a181d357c58ce43efba Gerrit-Change-Number: 29918 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sun, 30 Oct 2022 21:26:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
