fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/29929 )
Change subject: trxcon: fixup: trx_if_cmd_poweroff(): do not complain if
trx->powered_up
......................................................................
trxcon: fixup: trx_if_cmd_poweroff(): do not complain if trx->powered_up
In commit [1] I introduced a regression by removing the conditional
part completely. My intention was to remove the logging statement,
the return should be kept to prevent sending POWERON twice.
This regression affects the following TTCN-3 testcases:
* TC_sacch_chan_act_ho_async,
* TC_sacch_chan_act_ho_sync.
Change-Id: Iccd0bbac91a7899ef72df3dfe623b56eb66305fa
Fixes: [1] 1c75c0012b621d6cc7194d70d79a8198eb7fddb1
---
M src/host/trxcon/src/trx_if.c
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/host/trxcon/src/trx_if.c b/src/host/trxcon/src/trx_if.c
index 3e1bb79..6ae00f3 100644
--- a/src/host/trxcon/src/trx_if.c
+++ b/src/host/trxcon/src/trx_if.c
@@ -259,6 +259,8 @@
static int trx_if_cmd_poweron(struct trx_instance *trx)
{
+ if (trx->powered_up)
+ return -EAGAIN;
return trx_ctrl_cmd(trx, 1, "POWERON", "");
}
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29929
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iccd0bbac91a7899ef72df3dfe623b56eb66305fa
Gerrit-Change-Number: 29929
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
