Hello Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/5095

to look at the new patch set (#2).

auth: remove unused structs

The following structs are no longer used/needed:

- gsm_auth_algo
- gsm_auth_info
- gsm_auth_tuple
- gsm_security_operation

Change-Id: I93873a6cb980a54e03e719170e27a7e397236b77
---
M include/osmocom/bsc/gsm_data.h
1 file changed, 0 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/5095/2

diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 857dd4f..5190a27 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -55,35 +55,6 @@
                     struct msgb *msg,
                     void *data, void *param);
 
-/* Real authentication information containing Ki */
-enum gsm_auth_algo {
-       AUTH_ALGO_NONE,
-       AUTH_ALGO_XOR,
-       AUTH_ALGO_COMP128v1,
-};
-
-struct gsm_auth_info {
-       enum gsm_auth_algo auth_algo;
-       unsigned int a3a8_ki_len;
-       uint8_t a3a8_ki[16];
-};
-
-struct gsm_auth_tuple {
-       int use_count;
-       int key_seq;
-       struct osmo_auth_vector vec;
-};
-#define GSM_KEY_SEQ_INVAL      7       /* GSM 04.08 - 10.5.1.2 */
-
-/*
- * AUTHENTICATION/CIPHERING state
- */
-struct gsm_security_operation {
-       struct gsm_auth_tuple atuple;
-       gsm_cbfn *cb;
-       void *cb_data;
-};
-
 /*
  * A dummy to keep a connection up for at least
  * a couple of seconds to work around MSC issues.
@@ -154,12 +125,6 @@
        uint8_t expire_timer_stopped;
        /* SMS helpers for libmsc */
        uint8_t next_rp_ref;
-
-       /*
-        * Operations that have a state and might be pending
-        */
-       struct gsm_security_operation *sec_operation;
-       struct gsm_anchor_operation *anch_operation;
 
        struct osmo_fsm_inst *conn_fsm;
 

-- 
To view, visit https://gerrit.osmocom.org/5095
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93873a6cb980a54e03e719170e27a7e397236b77
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>

Reply via email to