Attention is currently required from: Hoernchen. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30153 )
Change subject: conrtrib/upload : upload elf files ...................................................................... Patch Set 2: Code-Review-1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/simtrace2/+/30153/comment/ff02b776_528cf67f PS2, Line 15: device will end up in DFU mode upon reset. I suggest to put this warning visibly elsewhere too (in a manual that already explains how to upgrade the firmware or something?), not many people will read it here in this commit message. Patchset: PS2: -1: might be a | missing File contrib/prepare_upload.sh: https://gerrit.osmocom.org/c/simtrace2/+/30153/comment/9d0039f3_6f03e6cd PS2, Line 12: b is a | missing here? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ifceb16d385388356ac1bf8b13f5df62c643bebf8 Gerrit-Change-Number: 30153 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Comment-Date: Tue, 15 Nov 2022 10:34:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
