Attention is currently required from: osmith, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30158 )
Change subject: osmux: Rotate over available Osmux CID when allocating a new one ...................................................................... Patch Set 1: (1 comment) File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/30158/comment/a990d1c6_98f7734d PS1, Line 67: <= > should probably be <, otherwise you check start_i twice? it's also < below > for the start_j check No, it must be <=. See for instance scenario where you start with next_free_osmux_cid_lookup=3 and all but 0, 1, 2 are occupied. You start with i=0,j=3 in the first loop, you reach the end of the array. You start then the 2nd loop, and you need to check the case where i=0 because you still have to check j=0,1,2. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I72803fb172accbabfc81923572890f8ecb06cefd Gerrit-Change-Number: 30158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Tue, 15 Nov 2022 14:52:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
