Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/30168 )

Change subject: osmux: dup in RTP pkt: Replace potentially internally forged 
pkt with incoming one
......................................................................


Patch Set 1:

(2 comments)

File src/osmux_input.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1032):
https://gerrit.osmocom.org/c/libosmo-netif/+/30168/comment/5b8d4c1f_b36a0abc
PS1, Line 473:                  } else {
else is not generally useful after a break or return


File tests/osmux/osmux_input_test.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1032):
https://gerrit.osmocom.org/c/libosmo-netif/+/30168/comment/ca8412b5_59cd1f12
PS1, Line 430:  osmux_pl = (uint8_t*)osmuxh + sizeof(*osmuxh);
"(foo*)" should be "(foo *)"



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30168
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I82e11ef3dcd20ffea33c94ed83abcedf0f186871
Gerrit-Change-Number: 30168
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 15 Nov 2022 17:21:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to