laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/simtrace2/+/30189 )


Change subject: firmware/sniffer: Disable TIMEOUT interrupts in USART IER on 
exit
......................................................................

firmware/sniffer: Disable TIMEOUT interrupts in USART IER on exit

Not critical (we disable the USART interrupts in NVIC anyway), but
if Sniffer_init() enables this flag, it's good style for Sniffer_exit()
to disable it.

Change-Id: I92e16a160d60fcab33c81e0cf074088b9f20b9ae
---
M firmware/libcommon/source/sniffer.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/89/30189/1

diff --git a/firmware/libcommon/source/sniffer.c 
b/firmware/libcommon/source/sniffer.c
index 56f0b64..aeb2a5e 100644
--- a/firmware/libcommon/source/sniffer.c
+++ b/firmware/libcommon/source/sniffer.c
@@ -913,7 +913,7 @@
 {
        TRACE_INFO("Sniffer exit\n\r");
        /* Disable USART */
-       USART_DisableIt(sniff_usart.base, US_IER_RXRDY);
+       USART_DisableIt(sniff_usart.base, US_IER_RXRDY | US_IER_TIMEOUT);
        /* NOTE: don't forget to set the IRQ according to the USART peripheral 
used */
        NVIC_DisableIRQ(IRQ_USART_SIM);
        USART_SetReceiverEnabled(sniff_usart.base, 0);

--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30189
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I92e16a160d60fcab33c81e0cf074088b9f20b9ae
Gerrit-Change-Number: 30189
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-MessageType: newchange

Reply via email to