Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30120 )
Change subject: [codecs filter] MT call: apply BSS codec list ...................................................................... Patch Set 1: (1 comment) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/30120/comment/b126db84_a9043d85 PS1, Line 685: codec_filter_set_bss(&trans->cc.codecs, &trans->msc_a->cc.compl_l3_codec_list_bss_supported); > (related to previous commit) See, you are no calling run() here. i also stumbled on this when separating the patches, but this place here is so early in the CC that it hardly makes sense to run the filter now. sounds like i am contradicting my previous comment ("cheap to run, rather run too often") -- well, i do know that the result of this patch series is able to establish voice calls accurately and hope to not spend more time on these marginal aspects now... -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I530409a64d11da48518a3dc60aa3a4e47c384663 Gerrit-Change-Number: 30120 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 16 Nov 2022 23:00:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
