Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30195 )
Change subject: osmux: Avoid filling in seqnum holes upon rx of RTP pkt with M bit set ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: > this seems to contradict https://gerrit.osmocom. […] Those are 2 different RTP packets, see my other comment here. File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30195/comment/680e5f2a_a41c5466 PS3, Line 488: clone_req.rtph->marker = false; > You can drop this again then No, the fact that the currently incoming RTP packet being enqueued has no M bit set (as asserted by code added in line 438) has nothing to do with the fact that the last RTP packet which wa previously enqueued ("last" ptr) has the M bit set or not. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I561fb836989d31f43a15b193ed9bec4103ea0f2b Gerrit-Change-Number: 30195 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Thu, 17 Nov 2022 11:16:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
