Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/30116 )

Change subject: [codecs filter] add codec_filter.h,c
......................................................................


Patch Set 1:

(1 comment)

File src/libmsc/codec_filter.c:

https://gerrit.osmocom.org/c/osmo-msc/+/30116/comment/4f5cb35a_f86dcefa
PS1, Line 124:  /* If osmo-msc were able to trigger a re-assignment after the 
remote side has picked a codec mismatching the
> yes. […]
Okk good. Maybe simply add a "#define ALLOW_REASSIGNMENT 0" on top of the file 
and potentially add there a comment pointing to a ticket explaining what can be 
done to improve it?



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30116
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4d90f7ca62f2307a7b93dd164aeecbf4bd98ff0a
Gerrit-Change-Number: 30116
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Thu, 17 Nov 2022 11:20:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to