Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30216 )
Change subject: tbf_fsm: Move osmo_fsm_inst fi out of struct tbf_fsm_ctx ...................................................................... Patch Set 2: (1 comment) File src/tbf.h: https://gerrit.osmocom.org/c/osmo-pcu/+/30216/comment/e6672579_6bb423ed PS1, Line 260: state_fi > Because there are several fi on a TBF controling different stuff. […] But this is one is the main tbf_fsm, right? Both ul_ass_fsm and dl_ass_fsm are supplementary ones, AFAICS. IMO, it's even more confusing now: you have 'state_fi' and 'state_fsm'. And why the internal fsm data (i.e. tbf_ul_ass_fsm_ctx, tbf_ul_ass_fsm_ctx, and tbf_fsm_ctx) is available here? Shouldn't it be dynamically allocated and assigned to fi->priv? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I03e691ccf6a94431caa55653349158f5b85db017 Gerrit-Change-Number: 30216 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:32:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
