Patch Set 7: Code-Review+1 (3 comments)
https://gerrit.osmocom.org/#/c/4771/7//COMMIT_MSG Commit Message: Line 10: interface. This will allow to move it to a different thread or I think you should mention that it is an interface. ;) ;) https://gerrit.osmocom.org/#/c/4771/7/src/host/layer23/src/mobile/primitives.c File src/host/layer23/src/mobile/primitives.c: Line 39: intf->ms = ms; depends on the usage, but ... if the osmocom_ms gets freed, should there be a safeguard to tear down / invalidate the prim_intf->ms as well? Line 101: (ws) -- To view, visit https://gerrit.osmocom.org/4771 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2456b7fae35546553c4805f12a40c0812d9255c Gerrit-PatchSet: 7 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
