Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30244 )
Change subject: LAPD: move tx_hist code into static function ...................................................................... Patch Set 4: -Code-Review (1 comment) File src/gsm/lapd_core.c: https://gerrit.osmocom.org/c/libosmocore/+/30244/comment/248673cc_549895c0 PS4, Line 1916: dl->tx_hist[h].msg = lapd_msgb_alloc(msg->len, "HIST"); > is h always 0 here? because you are replacing it with 0 in this patch... Good catch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibf3b08c8d874416796b94ba3a672a02d614313b1 Gerrit-Change-Number: 30244 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Mon, 21 Nov 2022 09:45:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
