Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30244 )
Change subject: LAPD: move tx_hist code into static functions ...................................................................... Patch Set 7: Code-Review-1 (1 comment) File src/gsm/lapd_core.c: https://gerrit.osmocom.org/c/libosmocore/+/30244/comment/244dcc91_6667f6a4 PS7, Line 1750: msg_to_tx_hist0 I don't like this. Why not pass a struct lapd_history pointer (be it &dl->tx_hist[h] or &dl->tx_hist[0]) directly to msg_to_tx_hist()? You're not accessing any other fields in dl anyway, AFAICS. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibf3b08c8d874416796b94ba3a672a02d614313b1 Gerrit-Change-Number: 30244 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Mon, 21 Nov 2022 12:28:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
