Attention is currently required from: laforge, tnt.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/30261 )

Change subject: conv_codes_gsm: Cosmetic improvements
......................................................................


Patch Set 1:

(3 comments)

File utils/conv_codes_gsm.py:

https://gerrit.osmocom.org/c/libosmocore/+/30261/comment/e2dacbbb_36b1a67a
PS1, Line 390: 98 - 6
It was 98 before this patch, and now becomes 92.
If it's an intentional change, I would expect it to be done in a separate patch.


https://gerrit.osmocom.org/c/libosmocore/+/30261/comment/225633ef_a624a956
PS1, Line 576: 190 - 6
same here


https://gerrit.osmocom.org/c/libosmocore/+/30261/comment/9d31c4f4_96f30c95
PS1, Line 590: 238 - 6
same here



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30261
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7cc6056114f997b5d4febf612ecd347b2d6d69b1
Gerrit-Change-Number: 30261
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: tnt <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: tnt <[email protected]>
Gerrit-Comment-Date: Mon, 21 Nov 2022 20:59:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to