osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/30268 )
Change subject: Cosmetic: lchan_fsm: drop obsolete comment
......................................................................
Cosmetic: lchan_fsm: drop obsolete comment
Neels wrote:
> i guess we can drop this comment now, it is a remnant from separating
> osmo-nitb -> osmo-bsc + osmo-ms
Change-Id: I2ce4d691715c1ea5c7c7896693a03b0aefbdb5b9
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 0 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/68/30268/1
diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index b1cef5d..2931f8f 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -1530,16 +1530,6 @@
lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;
lchan->release.rr_cause =
bsc_gsm48_rr_cause_from_rsl_cause(lchan->release.rsl_error_cause);
lchan_fsm_state_chg(LCHAN_ST_WAIT_AFTER_ERROR);
- /* TODO: we used to do this only for sysmobts:
- int do_free = is_osmobts(ts->trx->bts);
- LOGP(DRSL, LOGL_NOTICE,
- "%s CHAN REL ACK for broken channel. %s.\n",
- gsm_lchan_name(lchan),
- do_free ? "Releasing it" : "Keeping it broken");
- if (do_free)
- do_lchan_free(lchan);
- * Clarify the reason. If a BTS sends a RF Chan Rel ACK, we can
consider it released,
- * independently from the BTS model, right?? */
return;
case LCHAN_EV_RTP_RELEASED:
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30268
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2ce4d691715c1ea5c7c7896693a03b0aefbdb5b9
Gerrit-Change-Number: 30268
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-MessageType: newchange
